Skip to content

Include poststratify tutorial in docs build#143

Closed
neuralsorcerer wants to merge 1 commit intofacebookresearch:mainfrom
neuralsorcerer:doc
Closed

Include poststratify tutorial in docs build#143
neuralsorcerer wants to merge 1 commit intofacebookresearch:mainfrom
neuralsorcerer:doc

Conversation

@neuralsorcerer
Copy link
Copy Markdown
Collaborator

@neuralsorcerer neuralsorcerer commented Nov 12, 2025

Made sure the docs build script creates the tutorials HTML output directory and generates HTML for the poststratify quickstart notebook so the tutorial page is published correctly. Also cleaned up title formatting.

@meta-cla meta-cla bot added the cla signed label Nov 12, 2025
@neuralsorcerer
Copy link
Copy Markdown
Collaborator Author

neuralsorcerer commented Nov 12, 2025

Hmm, interesting. Trimming weight is failing only for a specific python version. It seems numeric stability might be the issue here.

@talgalili
Copy link
Copy Markdown
Contributor

talgalili commented Nov 12, 2025

LGTM.

The error seems transient (not clear where it came from)

@meta-codesync
Copy link
Copy Markdown

meta-codesync bot commented Nov 12, 2025

@talgalili has imported this pull request. If you are a Meta employee, you can view this in D86887871.

@talgalili
Copy link
Copy Markdown
Contributor

talgalili commented Nov 12, 2025

Hmm, interesting. Trimming weight is failing only for a specific python version. It seems numeric stability might be the issue here.

Yes.
If you want to fix it in another PR - that would be great .

@neuralsorcerer
Copy link
Copy Markdown
Collaborator Author

neuralsorcerer commented Nov 12, 2025

Yes. If you want to fix it in another PR - that would be great .

Need to look into it thoroughly. Will definitely raise a PR if I found any solution :)

@talgalili
Copy link
Copy Markdown
Contributor

talgalili commented Nov 12, 2025

Created an issue
https://github.com/facebookresearch/balance/issues

I'll re-run the test.

@talgalili
Copy link
Copy Markdown
Contributor

talgalili commented Nov 12, 2025

The test passed fine now.

@meta-codesync meta-codesync bot closed this in e1b0924 Nov 12, 2025
@meta-codesync
Copy link
Copy Markdown

meta-codesync bot commented Nov 12, 2025

@talgalili merged this pull request in e1b0924.

@neuralsorcerer neuralsorcerer deleted the doc branch November 12, 2025 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

cla signed Merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@neuralsorcerer @talgalili @facebook-github-bot