@talgalili has imported this pull request. If you are a Meta employee, you can view this in D86672684.

Thanks @neuralsorcerer - this is super cool!

Since this is a 'big deal' change, could you please:

1. Consider buffing up the tests for raking - just to make sure we're not missing any edge cases for this change? (if you think it's good as is, then feel free to keep it as is). Test file: https://github.com/facebookresearch/balance/blob/main/tests/test_rake.py
2. Add code (and output) for doing a benchmark before and after the change - just so we'll get a sense of the gain? while I like skipping ipdf from the dependency, I want to make sure there are no edge cases that ipfn will solve now (or in the future), that we will miss.

WDYT?

1. Consider buffing up the tests for raking - just to make sure we're not missing any edge cases for this change? (if you think it's good as is, then feel free to keep it as is)

I was planning to add more tests incrementally in upcoming PRs. I am happy to add more tests in this PR if we are fine with it.

2. Add code (and output) for doing a benchmark before and after the change - just so we'll get a sense of the gain? while I like skipping ipdf from the dependency, I want to make sure there are no edge cases that ipfn will solve now (or in the future), that we will miss.

That's a great suggestion. Will do it :)

@neuralsorcerer has updated the pull request. You must reimport the pull request before landing.

@neuralsorcerer has updated the pull request. You must reimport the pull request before landing.

Added benchmark_ipfn.py file under benchmark folder for the benchmark code.

Great job, thanks @neuralsorcerer !

I'm working to get this land in the coming hour.

FYI @neuralsorcerer
Just wanted to let you know I'm still working on this diff and that it hasn't landed yet because there are a bunch of internal errors I'm sorting out on the files. I suspect it will land within 24 hours after I finish fixing them.

No hurries and thank you for working on it @talgalili

@talgalili merged this pull request in 21d657a.