Fix quantize column ordering and error handling#133
Closed
neuralsorcerer wants to merge 2 commits intofacebookresearch:mainfrom
Closed
Fix quantize column ordering and error handling#133neuralsorcerer wants to merge 2 commits intofacebookresearch:mainfrom
neuralsorcerer wants to merge 2 commits intofacebookresearch:mainfrom
Conversation
Contributor
|
Thanks @neuralsorcerer for the PR! Thanks! |
Collaborator
Author
|
Hi @talgalili, updated with proper tests. |
|
@talgalili has imported this pull request. If you are a Meta employee, you can view this in D86596456. |
Contributor
|
Thanks for the diff @neuralsorcerer - it's about to land. |
Collaborator
Author
|
Absolutely, will try my best 😃 |
|
@talgalili merged this pull request in 811c269. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
TypeErrorexceptions to provide clearer feedback on invalid inputs.