Skip to content

[BUG] rake doesn't support trimming - but also doesn't indicate it to the user #69

@talgalili

Description

@talgalili

This is violating user expectation.

E.g.:

weights_untrimmed = sample.adjust(
    variables=weighting_variables,
    method="rake",
    weight_trimming_mean_ratio=0,
    transformations=auto_recodes,
)

By expectation violation I mean,

  1. there isn’t anything in the docs that suggests that rake doesn’t support weight_trimming_mean_ratio or weight_trimming_percentile
  2. there isn’t an error thrown when a value is passed to either weight_trimming_mean_ratio or weight_trimming_percentile suggesting that rake doesn’t support it.
  3. this can result people thinking the weights are getting trimmed when they aren’t.

(Reported by David Lovis-McMahon)

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions