Take over enhancements to render Draft.js in an iframe#1938
Take over enhancements to render Draft.js in an iframe#1938claudiopro wants to merge 17 commits into
Conversation
We do that to access them from whenever it's needed.
|
Thanks for taking it on @claudiopro. |
|
Thanks to you @haikyuu for working out most of the changes! I just took it from there 😄 |
claudiopro
changed the title
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@claudiopro has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@claudiopro is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
I'm pretty sure there's is a problem with the way you destructure your event targets (eg. I'm having errors in |
|
Thanks for the heads up @odusseys, do you mind sharing steps to reproduce the error? |
|
Eh I'm not a hundred percent sure anymore since I fixed it on my fork and don't really have time to reproduce it; but I think I just added the drag plugin from draft-js-plugins together with the image plugin, and dragging threw an error (ownerDocument was null). |
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@claudiopro has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
Hey @claudiopro what's the status on this one? anything i can do to help? |
|
Any updates on this y'all? |
|
@claudiopro @haikyuu thank you for your work on this. I was able to make it work pretty seamlessly with the latest version of Draft by replicating your commits. (Just needed to add an isHTMLBRElement check in the style of isHTMLAnchorElement etc.) |
|
@jack-arms merged this pull request in dceddf5. |
…ve#1938) Summary: **Summary** Takes over and applies requested PR feedback to facebookarchive#1877 by haikyuu. Refer to original PR for context and discussion. **Test Plan** Run some manual smoke tests on the editor running in an iframe as follows: ``` yarn python3 -m http.server 8080 . open http://localhost:8080/examples/draft-0-10-0/iframe/iframe.html ``` Pull Request resolved: facebookarchive#1938 Reviewed By: claudiopro Differential Revision: D13137413 Pulled By: jack-arms fbshipit-source-id: efcdbabc7d8d2aff4fbebc8b06c22d57756ebc12
…ve#1938) Summary: **Summary** Takes over and applies requested PR feedback to facebookarchive#1877 by haikyuu. Refer to original PR for context and discussion. **Test Plan** Run some manual smoke tests on the editor running in an iframe as follows: ``` yarn python3 -m http.server 8080 . open http://localhost:8080/examples/draft-0-10-0/iframe/iframe.html ``` Pull Request resolved: facebookarchive#1938 Reviewed By: claudiopro Differential Revision: D13137413 Pulled By: jack-arms fbshipit-source-id: efcdbabc7d8d2aff4fbebc8b06c22d57756ebc12
Summary: **Summary** Takes over and applies requested PR feedback to #1877 by haikyuu. Refer to original PR for context and discussion. **Test Plan** Run some manual smoke tests on the editor running in an iframe as follows: ``` yarn python3 -m http.server 8080 . open http://localhost:8080/examples/draft-0-10-0/iframe/iframe.html ``` Pull Request resolved: facebookarchive/draft-js#1938 Reviewed By: claudiopro Differential Revision: D13137413 Pulled By: jack-arms fbshipit-source-id: efcdbabc7d8d2aff4fbebc8b06c22d57756ebc12
5 participants
Summary
Takes over and applies requested PR feedback to #1877 by @haikyuu.
Refer to original PR for context and discussion.
Test Plan
Run some manual smoke tests on the editor running in an iframe as follows: