[fix] Added UNAME_TARGET_SYSTEM to make shared lib compile flag selection configurable#4220
Merged
Conversation
Cyan4973
approved these changes
Dec 19, 2024
Contributor
|
This is a good stop-gap, it allows a user to manually take control of the situation, without impacting the current default behavior. I presume that a more robust solution would likely employ the output of the compiler to determine what's the target, but that's more work and more risk, which can be attempted later. As a side note, |
Contributor
Author
|
Exactly, the Line 212 in 0218c8d |
Contributor
|
Thanks for the PR @RicBent! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4219 by adding
UNAME_TARGET_SYSTEMwhich, when not set, defaults toUNAME.