cmake: Fix #4038 MacOS target older OS and SDK versions#4191
Conversation
This fix ensures that when `MACOSX_DEPLOYMENT_TARGET` and `SDKROOT` are set, they are respected when building the libraries and executables.
|
Hi @lukaso! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
3 participants
This fix ensures that when
MACOSX_DEPLOYMENT_TARGETandSDKROOTare set, they are respected when building the libraries and executables.How to test (on a MacOS machine):
You will have to download an older SDK version. In this case I'm using 11.3.
The output will include:
Without this fix, the output will looks something like:
Depending on the version of MacOS installed and the SDK installed.