Conversation
not as good as small-blocks improvement, but generally positive.
terrelln
approved these changes
Oct 16, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch generally improves dictionary compression speed for the
faststrategy, aka levels 1 & 2, following a method similar to #4165 .The gains are not uniform, and depend on the shape of the data. Tested on a set of various scenarios, one can observe speed gains as large as +14%, and as low as -2%, with the majority being around +5%. Therefore, this change is mostly positive, and when it's not, it's just by a small amount.
I also tried the same modification for
dfaststrategy, aka levels 3 & 4, but did not observe similar speed gains. That being said, during the investigation process, a few minor modifications were made to thedfastdictionary compression code, leading generally to slightly better compression ratios, by favoring longer matches over short ones.