Fixed warning when compiling pzstd with CPPFLAGS=-Wunused-result and …#4134
Merged
Conversation
…CXXFLAGS=-std=c++17
Cyan4973
approved these changes
Aug 31, 2024
Contributor
|
I don't think this is right. The code seems to be wanting to do https://en.wikipedia.org/wiki/Erase%E2%80%93remove_idiom Meaning is the proper solution. It doesn't affect anything since this is contrib and not really used. edit: as the wiki page states, this should be using std::erase_if and not std::remove_if. But that needs C++20. |
terrelln
approved these changes
Sep 25, 2024
Contributor
|
Thanks for the bug fix @inventor500 & @neheb! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should close #4133.
This problem is not particularly important, since this was a build warning and does not seem to effect anything, but it does remove a warning when compiling on GCC.