Bugfixed Visual Studio errors when compiled as C++ sources by r-lyeh-archived · Pull Request #4 · facebook/zstd

r-lyeh-archived · 2015-01-26T09:27:48Z

Hello Yann,

Here you have a few missing casts.
They're not required in C, but library will fail to compile in C++ mode otherwise
(reproduce it by typìng cl.exe /Tp fse.c and cl.exe /Tp zstd.c)

Great library.
Keep up the good work.

r-lyeh

PS: I have kept your identation style when creating the type casts. Also, see errors bugfixed below:

fse.c(135) : error C2440: 'initializing' : cannot convert from 'const void *' to 'const BYTE *' Conversion from 'void*' to pointer to non-'void' requires an explicit cast
fse.c(148) : error C2440: 'initializing' : cannot convert from 'void *' to 'BYTE *' Conversion from 'void*' to pointer to non-'void' requires an explicit cast
fse.c(169) : error C2440: 'initializing' : cannot convert from 'const void *' to 'const BYTE *' Conversion from 'void*' to pointer to non-'void' requires an explicit cast
fse.c(183) : error C2440: 'initializing' : cannot convert from 'void *' to 'BYTE *' Conversion from 'void*' to pointer to non-'void' requires an explicit cast
fse.c(621) : error C2440: 'initializing' : cannot convert from 'const void *' to 'const rank_t *' Conversion from 'void*' to pointer to non-'void' requires an explicit cast
fse.c(622) : error C2440: 'initializing' : cannot convert from 'const void *' to 'const rank_t *' Conversion from 'void*' to pointer to non-'void' requires an explicit cast
fse.c(1008) : error C2440: 'initializing' : cannot convert from 'void *' to 'U32 *const ' Conversion from 'void*' to pointer to non-'void' requires an explicit cast
fse.c(1026) : error C2440: 'initializing' : cannot convert from 'void *' to 'U32 *const ' Conversion from 'void*' to pointer to non-'void' requires an explicit cast
fse.c(1145) : error C2440: 'initializing' : cannot convert from 'const void *' to 'const U32 *const ' Conversion from 'void*' to pointer to non-'void' requires an explicit cast
fse.c(1514) : error C2440: 'initializing' : cannot convert from 'void *' to 'U32 *const ' Conversion from 'void*' to pointer to non-'void' requires an explicit cast

zstd.c(205) : error C2440: 'initializing' : cannot convert from 'const void *' to 'const BYTE *' Conversion from 'void*' to pointer to non-'void' requires an explicit cast
zstd.c(206) : error C2440: 'initializing' : cannot convert from 'void *' to 'BYTE *' Conversion from 'void*' to pointer to non-'void' requires an explicit cast
zstd.c(213) : error C2440: 'initializing' : cannot convert from 'void *' to 'BYTE *const ' Conversion from 'void*' to pointer to non-'void' requires an explicit cast
zstd.c(230) : error C2440: 'initializing' : cannot convert from 'const void *' to 'const BYTE *const ' Conversion from 'void*' to pointer to non-'void' requires an explicit cast
zstd.c(279) : error C2440: 'initializing' : cannot convert from 'ZSTD_cctx_t' to 'refTables_t *' Conversion from 'void*' to pointer to non-'void' requires an explicit cast
zstd.c(440) : error C2440: 'initializing' : cannot convert from 'void *' to 'BYTE *const ' Conversion from 'void*' to pointer to non-'void' requires an explicit cast
zstd.c(461) : error C2440: 'initializing' : cannot convert from 'void *' to 'BYTE *const ' Conversion from 'void*' to pointer to non-'void' requires an explicit cast
zstd.c(954) : error C2664: 'size_t ZSTD_compressEntropy(BYTE *,size_t,const BYTE *,const BYTE *,const BYTE *,const BYTE *,const BYTE *,const U32 *,const BYTE *,const BYTE *,size_t,size_t)' : cannot convert argument 1 from 'void *' to 'BYTE *' Conversion from 'void*' to pointer to non-'void' requires an explicit cast
zstd.c(1001) : error C2440: 'initializing' : cannot convert from 'const void *' to 'const BYTE *const ' Conversion from 'void*' to pointer to non-'void' requires an explicit cast
zstd.c(1003) : error C2440: 'initializing' : cannot convert from 'void *' to 'BYTE *const ' Conversion from 'void*' to pointer to non-'void' requires an explicit cast
zstd.c(1009) : error C2440: '=' : cannot convert from 'const void *' to 'const BYTE *' Conversion from 'void*' to pointer to non-'void' requires an explicit cast
zstd.c(1013) : error C2440: '=' : cannot convert from 'const void *' to 'const BYTE *' Conversion from 'void*' to pointer to non-'void' requires an explicit cast
zstd.c(1068) : error C2440: 'initializing' : cannot convert from 'void *' to 'BYTE *' Conversion from 'void*' to pointer to non-'void' requires an explicit cast
zstd.c(1085) : error C2440: 'initializing' : cannot convert from 'void *' to 'BYTE *const ' Conversion from 'void*' to pointer to non-'void' requires an explicit cast
zstd.c(1133) : error C2440: 'initializing' : cannot convert from 'const void *' to 'const BYTE *const ' Conversion from 'void*' to pointer to non-'void' requires an explicit cast
zstd.c(1142) : error C2440: '=' : cannot convert from 'int' to 'blockType_t' Conversion to enumeration type requires an explicit cast (static_cast, C-style cast or function-style cast)
zstd.c(1233) : error C2440: 'initializing' : cannot convert from 'const void *' to 'const BYTE *' Conversion from 'void*' to pointer to non-'void' requires an explicit cast
zstd.c(1261) : error C2440: 'initializing' : cannot convert from 'const void *' to 'const BYTE *const ' Conversion from 'void*' to pointer to non-'void' requires an explicit cast
zstd.c(1263) : error C2440: 'initializing' : cannot convert from 'void *' to 'BYTE *const ' Conversion from 'void*' to pointer to non-'void' requires an explicit cast
zstd.c(1303) : error C2440: 'initializing' : cannot convert from 'const void *' to 'const BYTE *const ' Conversion from 'void*' to pointer to non-'void' requires an explicit cast
zstd.c(1397) : error C2440: 'initializing' : cannot convert from 'const void *' to 'const BYTE *' Conversion from 'void*' to pointer to non-'void' requires an explicit cast
zstd.c(1399) : error C2440: 'initializing' : cannot convert from 'void *' to 'BYTE *const ' Conversion from 'void*' to pointer to non-'void' requires an explicit cast
zstd.c(1561) : error C2440: 'initializing' : cannot convert from 'const void *' to 'const BYTE *' Conversion from 'void*' to pointer to non-'void' requires an explicit cast
zstd.c(1563) : error C2440: 'initializing' : cannot convert from 'void *' to 'BYTE *const ' Conversion from 'void*' to pointer to non-'void' requires an explicit cast
zstd.c(1640) : error C2440: 'initializing' : cannot convert from 'void *' to 'dctx_t *' Conversion from 'void*' to pointer to non-'void' requires an explicit cast
zstd.c(1698) : error C2440: 'initializing' : cannot convert from 'const void *' to 'const BYTE *' Conversion from 'void*' to pointer to non-'void' requires an explicit cast

Bugfixed Visual Studio errors when compiled as C++ sources

Cyan4973 · 2015-01-26T10:06:02Z

Thanks, it's a straightforward and very useful patch for C++

r-lyeh-archived · 2015-01-26T10:25:44Z

👍 🍺

pull from facebook/zstd

# This is the 1st commit message: Make paramgrill use bench.c benchmarking # This is the commit message facebook#2: Minor changes # This is the commit message facebook#3: Explicit casting # This is the commit message facebook#4: Makefile fix # This is the commit message facebook#5: casting, type fix

merge

Merging dev

…acebook#4) * Update audiocore to pull a version from S3 to use in build process * Added instruction to push and pull files

Bugfixed Visual Studio errors when compiled as C++ sources

0da7941

Cyan4973 added a commit that referenced this pull request Jan 26, 2015

Merge pull request #4 from r-lyeh/dev

f10532a

Bugfixed Visual Studio errors when compiled as C++ sources

Cyan4973 merged commit f10532a into facebook:dev Jan 26, 2015

r-lyeh-archived deleted the dev branch January 26, 2015 10:25

Cyan4973 pushed a commit that referenced this pull request Jun 28, 2017

Merge pull request #4 from facebook/dev

d2e2441

pull from facebook/zstd

Cyan4973 pushed a commit that referenced this pull request Jun 19, 2019

Merge pull request #4 from facebook/dev

bc400ed

merge

Cyan4973 pushed a commit that referenced this pull request Oct 24, 2019

Merge pull request #4 from facebook/dev

95f7880

Merging dev

Sanmayce mentioned this pull request Jan 27, 2022

FEEDBACK: 'Fulg' - Textual_[De]Compression_Showdown - REPRODUCIBLE Benchmark #3024

Closed

ShenglongWang mentioned this pull request Jun 8, 2022

HIST_count_wksp segment fault #3156

Closed

Sanmayce mentioned this pull request Mar 2, 2023

Benchmarking Zstd versus 14 decompressors #3521

Closed

sb22bs mentioned this pull request Mar 21, 2023

I can only compile and link zstd on CentOS 6 if I add -lrt option to the linker options #3558

Closed

zh-wen mentioned this pull request Jun 7, 2023

The simple_compression in examples fails with SIGSEGV，using a special set of use caces #3670

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bugfixed Visual Studio errors when compiled as C++ sources#4

Bugfixed Visual Studio errors when compiled as C++ sources#4
Cyan4973 merged 1 commit intofacebook:devfrom
r-lyeh-archived:dev

r-lyeh-archived commented Jan 26, 2015

Uh oh!

Cyan4973 commented Jan 26, 2015

Uh oh!

r-lyeh-archived commented Jan 26, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

r-lyeh-archived commented Jan 26, 2015

Uh oh!

Cyan4973 commented Jan 26, 2015

Uh oh!

r-lyeh-archived commented Jan 26, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants