Fix building on windows-x86 if clang already includes D101338#3998
Merged
terrelln merged 1 commit intofacebook:devfrom Apr 1, 2024
Merged
Fix building on windows-x86 if clang already includes D101338#3998terrelln merged 1 commit intofacebook:devfrom
terrelln merged 1 commit intofacebook:devfrom
Conversation
[D101338](https://reviews.llvm.org/D101338) landed in 2021, so clang16 should have it
Contributor
|
@georgthegreat I just saw your comment on 94c1020, thanks for reporting the issue! That code definitely needs to be updated to support 32-bits. And it looks like we are missing a 32-bit clang-cl CI job. I'll open an issue. |
terrelln
approved these changes
Apr 1, 2024
Contributor
|
I've filed #4010 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
D101338 landed in 2021, so clang16 should have it