The fix looks fine,
but I wonder if we could add, or update, a test,
that would trigger this problem without this fix.
This way, we would ensure that this property remains respected in the future.

I suspected we used to have a Windows clang-cl test on Appveyor,
but somehow it was lost in the transition towards Github Actions.

When you say test - do you mean a build bot in this case that would build zstd with clang-cl? I am not very familiar with the github actions workers and configurations, maybe someone else could help with that?

When you say test - do you mean a build bot in this case that would build zstd with clang-cl? I am not very familiar with the github actions workers and configurations, maybe someone else could help with that?

I'll look into it

I added a Clang-CL test in #3579, and it fails at link stage, as expected.

Now, I wonder if the exact way it fails is the expected one, as I don't recognise the gitlab issue :
https://github.com/facebook/zstd/actions/runs/4549108695/jobs/8020846731?pr=3579

lld-link : warning : ignoring unknown argument '-z' [D:\a\zstd\zstd\build\cmake\build\programs\zstd.vcxproj]
lld-link : error : could not open 'noexecstack': no such file or directory [D:\a\zstd\zstd\build\cmake\build\programs\zstd.vcxproj]

If yes, then it means that merging this PR, then rebasing #3579 on top of it, should fix the problem.

Great! Thanks for the CI build, that hopefully means that our configuration will continue to work in the future!