Skip to content

fullbench with two files #3516

Merged
Cyan4973 merged 1 commit intofacebook:devfrom
dloidolt:fullbench_2_files
Mar 6, 2023
Merged

fullbench with two files #3516
Cyan4973 merged 1 commit intofacebook:devfrom
dloidolt:fullbench_2_files

Conversation

@dloidolt
Copy link

When benchmarking two files with fullbench, the second file will not be benchmarked because the benchNb has not been reset to zero.
Screenshot 2023-02-20 at 16 55 30

…be benchmarked because the benchNb has not been reset to zero.
@facebook-github-bot
Copy link

Hi @dloidolt!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

1 similar comment
@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@Cyan4973 Cyan4973 self-assigned this Mar 6, 2023
@Cyan4973
Copy link
Contributor

Cyan4973 commented Mar 6, 2023

Thanks @dloidolt, it's nice simple fix that works well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants