Merged
Conversation
Contributor
|
Thanks @daniellerozenblit ! Great fix ! Another point : it seems we have been missing this issue, because we were lacking the relevant test to detect it. Could you add it to this PR too ? |
daniellerozenblit
force-pushed
the
fix-window-resize-test
branch
from
0722809 to
7da1c6d
Compare
daniellerozenblit
force-pushed
the
fix-window-resize-test
branch
from
631e797 to
d3d0b92
Compare
Cyan4973
approved these changes
Feb 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for issues #3501 and #3502.
All tests now seem to pass for
make -C tests test-cli-tests CFLAGS="-O2 -m32"andmake -C tests test-cli-tests HAVE_ZLIB=0.