Use correct types in LZMA comp/decomp#3497
Merged
yoniko merged 1 commit intofacebook:devfrom Feb 14, 2023
Merged
Conversation
Bytef and uInt are zlib types, not available when zlib is disabled Fixes: 1598e6c ("Async write for decompression") Fixes: cc0657f ("AsyncIO compression part 2 - added async read and asyncio to compression code (facebook#3022)")
Contributor
|
Thanks @Hello71 , I wonder if we should consider adding a test with |
yoniko
added a commit
to yoniko/zstd
that referenced
this pull request
Feb 14, 2023
…sors and with no external compressors. This is a sanity to make sure we don't introduce code dependencies on libraries that don't always exist (see facebook#3497 for an example bugfix for such issue).
yoniko
approved these changes
Feb 14, 2023
yoniko
added a commit
to yoniko/zstd
that referenced
this pull request
Feb 14, 2023
…sors and with no external compressors. This is a sanity to make sure we don't introduce code dependencies on libraries that don't always exist (see facebook#3497 for an example bugfix for such issue).
yoniko
added a commit
to yoniko/zstd
that referenced
this pull request
Feb 14, 2023
…sors and with no external compressors. This is a sanity to make sure we don't introduce code dependencies on libraries that don't always exist (see facebook#3497 for an example bugfix for such issue).
yoniko
added a commit
that referenced
this pull request
Feb 14, 2023
Implemented CI workflow for testing compilation with external compressors and without them. This serves as a sanity check to avoid any code dependencies on libraries that may not always be present. (Reference: #3497 for a bug fix related to this issue.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bytef and uInt are zlib types, not available when zlib is disabled
Fixes: 1598e6c ("Async write for decompression")
Fixes: cc0657f ("AsyncIO compression part 2 - added async read and asyncio to compression code (#3022)")