Fix empty-block.zst golden decompression file#3483
Merged
terrelln merged 1 commit intofacebook:devfrom Feb 8, 2023
Merged
Conversation
This frame is invalid because the `Window_Size = 0`, and the `Block_Maximum_Size = min(128 KB, Window_Size) = 0`. But the empty compressed block has a `Block_Content` size of 2, which is invalid. The fix is to switch to using a `Window_Descriptor` instead of the `Single_Segment_Flag`. This sets the `Window_Size = 1024`. Hexdump before this PR: `28b5 2ffd 2000 1500 0000 00` Hexdump after this PR: `28b5 2ffd 0000 1500 0000 00` For issue facebook#3482.
Cyan4973
approved these changes
Feb 8, 2023
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This frame is invalid because the
Window_Size = 0, and theBlock_Maximum_Size = min(128 KB, Window_Size) = 0. But the empty compressed block has aBlock_Contentsize of 2, which is invalid.The fix is to switch to using a
Window_Descriptorinstead of theSingle_Segment_Flag. This sets theWindow_Size = 1024.Hexdump before this PR:
28b5 2ffd 2000 1500 0000 00Hexdump after this PR:
28b5 2ffd 0000 1500 0000 00For issue #3482.