[tests] Remove deprecated function from longmatch.c test#3395
Merged
Cyan4973 merged 1 commit intofacebook:devfrom Dec 28, 2022
Merged
[tests] Remove deprecated function from longmatch.c test#3395Cyan4973 merged 1 commit intofacebook:devfrom
Cyan4973 merged 1 commit intofacebook:devfrom
Conversation
terrelln
force-pushed
the
2022-12-21-deprecated-test
branch
from
105ab9d to
4b40e40
Compare
Thanks to @eli-schwartz for pointing it out! We should maybe consider adding a helper function for applying `ZSTD_parameters` and `ZSTD_compressionParameters` to a context. That would aid the transition to the new API in situations like this.
Contributor
Indeed, I thought we already had one. But maybe it's only used internally. To be checked... |
Cyan4973
approved these changes
Dec 28, 2022
Cyan4973
added a commit
that referenced
this pull request
Dec 28, 2022
Inspired by #3395, offer a new capability to set all parameters defined in a ZSTD_compressionParameters structure with a single symbol invocation to improve user code brevity.
Merged
Cyan4973
added a commit
that referenced
this pull request
Dec 28, 2022
Inspired by #3395, offer a new capability to set all parameters defined in a ZSTD_compressionParameters structure with a single symbol invocation to improve user code brevity.
Cyan4973
added a commit
that referenced
this pull request
Dec 28, 2022
Inspired by #3395, offer a new capability to set all parameters defined in a ZSTD_compressionParameters structure with a single symbol invocation to improve user code brevity.
embg
pushed a commit
to embg/zstd
that referenced
this pull request
Jan 4, 2023
Inspired by facebook#3395, offer a new capability to set all parameters defined in a ZSTD_compressionParameters structure with a single symbol invocation to improve user code brevity.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks to @eli-schwartz for pointing it out!
We should maybe consider adding a helper function for applying
ZSTD_parametersandZSTD_compressionParametersto a context. That would aid the transition to the new API in situations like this.