[api][visibility] Make the visibility macros more consistent#3363
Merged
terrelln merged 1 commit intofacebook:devfrom Dec 16, 2022
Merged
[api][visibility] Make the visibility macros more consistent#3363terrelln merged 1 commit intofacebook:devfrom
terrelln merged 1 commit intofacebook:devfrom
Conversation
Contributor
|
OK, so switch to Also : we should probably document these build macros, |
1. Follow the scheme introduced in PR facebook#2501 for both `zdict.h` and `zstd_errors.h`. 2. If the `*_VISIBLE` macro isn't set, but the `*_VISIBILITY` macro is, use that. Also make this change for `zstd.h`, since we probably shouldn't have changed that macro name without backward compatibility in the first place. 3. Change all references to `*_VISIBILITY` to `*_VISIBLE`. Fixes facebook#3359.
Contributor
Author
|
Update README |
Cyan4973
approved these changes
Dec 16, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
zdict.handzstd_errors.h.*_VISIBLEmacro isn't set, but the*_VISIBILITYmacro is, use that. Also make this change forzstd.h, since we probably shouldn't have changed that macro name without backward compatibility in the first place.*_VISIBILITYto*_VISIBLE.ZDICTLIB_STATIC_APIto be consistent withzstd.h, this is a no-op change by default.lib/README.md.Fixes #3359.