Implement more gzip compatibility (#3037)#3059
Merged
felixhandte merged 1 commit intofacebook:devfrom Mar 8, 2022
Merged
Conversation
felixhandte
reviewed
Feb 8, 2022
Contributor
felixhandte
left a comment
felixhandte
left a comment
There was a problem hiding this comment.
These options should be documented in the CLI help text and in the man page. Can you add descriptions?
(If you'd prefer we do that part, we can add them in a follow-up PR.)
dirkmueller
changed the title
-n --no-name is the current behavior already, so we can implement this as a noop. --best is an alias for -9 in gzip add basic cli tests.
dirkmueller
force-pushed
the
gzip_fast_best
branch
from
479ef20 to
e653e97
Compare
Contributor
Author
|
@felixhandte Okay, wasn't sure as these options are just for better gzip compatibility and not exposed in standard zstd cli. anyway added. |
Contributor
Author
|
is there anything I can do to move this forward? |
felixhandte
approved these changes
Mar 8, 2022
Contributor
felixhandte
left a comment
felixhandte
left a comment
There was a problem hiding this comment.
Thanks for the reminder. Let's ship it!
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-n --no-name is the current behavior already, so we can implement
this as a noop.
--best is an alias for -9 in gzip
add basic cli tests.