Fix zstd-static output name with MINGW/Clang#2947
Fix zstd-static output name with MINGW/Clang#2947Cyan4973 merged 1 commit intofacebook:devfrom MehdiChinoune:patch-1
Conversation
|
Hi @MehdiChinoune! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
Cyan4973
left a comment
There was a problem hiding this comment.
This seems to match the intention of the script,
which specifies that this library name should only be used with MSVC.
I'm surprised we can't rely solely on the MSVC detection, even when using the clang back end, but hey, that's a different problem.
No description provided.