Allow user to specify memory limit for dictionary training#2925
Merged
embg merged 1 commit intofacebook:devfrom Dec 15, 2021
Merged
Allow user to specify memory limit for dictionary training#2925embg merged 1 commit intofacebook:devfrom
embg merged 1 commit intofacebook:devfrom
Conversation
Contributor
|
Looks good to me, except for |
Cyan4973
reviewed
Dec 14, 2021
Cyan4973
reviewed
Dec 14, 2021
embg
force-pushed
the
dict_training_sample_limit_size
branch
from
810a109 to
5cd8292
Compare
embg
force-pushed
the
dict_training_sample_limit_size
branch
from
5cd8292 to
71c0c07
Compare
Contributor
Author
|
Added a test which greps the stderr, and reverted zstd.1 changes (could not get ronn-ng working on Mac). |
Cyan4973
approved these changes
Dec 14, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #2809.