Add detection when compiling with Clang and Ninja under Windows#2877
Merged
Cyan4973 merged 1 commit intofacebook:devfrom Dec 1, 2021
Merged
Add detection when compiling with Clang and Ninja under Windows#2877Cyan4973 merged 1 commit intofacebook:devfrom
Cyan4973 merged 1 commit intofacebook:devfrom
Conversation
Prevents multiple rules error when building with ninja and clang under windows
Cyan4973
approved these changes
Nov 24, 2021
terrelln
approved these changes
Nov 30, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to the Clang documentation Clang creates MSVC-compatible libraries by default when compiling for Windows. This includes the names of the resulting library files.
This fixes the ninja error
multiple rules generate lib/zstd.lib [-w dupbuild=err]for Clang under Windows.Fixes #2248 and propably #2770