Add support for negative values in advanced flags#2705
Merged
binhdvo merged 1 commit intofacebook:devfrom Jun 11, 2021
Merged
Conversation
Cyan4973
requested changes
Jun 10, 2021
Contributor
Cyan4973
left a comment
Cyan4973
left a comment
There was a problem hiding this comment.
Let's discuss a rewording of this task for improved clarity
binhdvo
changed the title
Cyan4973
reviewed
Jun 11, 2021
Cyan4973
reviewed
Jun 11, 2021
Cyan4973
approved these changes
Jun 11, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes command line flag from #2703
Adds --long-level flag which behaves as -# except supporting negative values as fast compression levels.
--long- is intended to be the prefix for any future parameters that should have a version which accepts negative values.