Fuzzer test with no intrinsics on S390x (big endian)#2678
Merged
senhuang42 merged 1 commit intofacebook:devfrom Jun 9, 2021
Merged
Fuzzer test with no intrinsics on S390x (big endian)#2678senhuang42 merged 1 commit intofacebook:devfrom
senhuang42 merged 1 commit intofacebook:devfrom
Conversation
senhuang42
force-pushed
the
big_endian_no_intrinsics_fuzztest
branch
2 times, most recently
from
8d2ac84 to
fd4e5c4
Compare
senhuang42
force-pushed
the
big_endian_no_intrinsics_fuzztest
branch
from
fd4e5c4 to
c4786a0
Compare
Author
|
This has been updated to be merge-able after the changes to CI. |
senhuang42
force-pushed
the
big_endian_no_intrinsics_fuzztest
branch
from
c4786a0 to
2ff5c7b
Compare
Contributor
|
I see that a few tests on big endian platforms are failing, |
Author
I've just merged the PR with the fix into dev, and the tests now pass. |
Cyan4973
approved these changes
Jun 9, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks to @aqrit , a bug on big-endian systems with the row-based matchfinder was discovered - the scalar fallback wouldn't work on those systems. We add a test for S390X architectures.
Adds:
compress2with forced row matchfinder for compression ratio regressions