[CI][2/2] Migrate CI tests which (currently) fail#2677
Merged
senhuang42 merged 2 commits intofacebook:devfrom Aug 2, 2021
Merged
[CI][2/2] Migrate CI tests which (currently) fail#2677senhuang42 merged 2 commits intofacebook:devfrom
senhuang42 merged 2 commits intofacebook:devfrom
Conversation
Contributor
|
Whats the status of this PR? |
senhuang42
force-pushed
the
ci_overhaul_2
branch
from
767a0ae to
43aad81
Compare
senhuang42
force-pushed
the
ci_overhaul_2
branch
from
3b88170 to
8080279
Compare
Author
I've updated/rebased it so that now all it does is:
Even just doing (1, 2) requires some extra initializations to satisfy the static analyzers. So if we don't want to do that we can just abandon this PR since now the only actual novel thing it adds is a VS2019 test. |
senhuang42
force-pushed
the
ci_overhaul_2
branch
from
8080279 to
5ec7897
Compare
Cyan4973
approved these changes
Jul 30, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #2675 is a fairly involved change to the CI. This PR simply adds another commit on top of that which migrates the tests that are failing on #2675 due to various static analyzer warnings.
The intention is that PR #2675 can get merged first with all tests passing, then the static analyzer-related fixes will get coded and merged, and then this PR can get merged.
No need to review this until #2675 and the static analyzer fixes get merged.
This PR: