Initialize "potentially uninitialized" pointers.#2654
Merged
felixhandte merged 1 commit intofacebook:devfrom Jun 7, 2021
wolfpld:dev
Merged
Initialize "potentially uninitialized" pointers.#2654felixhandte merged 1 commit intofacebook:devfrom wolfpld:dev
felixhandte merged 1 commit intofacebook:devfrom
wolfpld:dev
Conversation
felixhandte
approved these changes
Jun 7, 2021
Contributor
felixhandte
left a comment
felixhandte
left a comment
There was a problem hiding this comment.
This is a reasonable fix for an unfortunate warning.
I worry that zealously fixing these false positives creates room for actually incorrect uses in the future. Initializing these values in this way allows for syntactically correct uses which are nonetheless semantically incorrect. But I don't think there's really anything we can do about that here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In certain configurations MSVC may enable some sort of a static analyser during compilation, which marks "unsafe" code constructs. In this case the error messages are:
Initialization and usage of both
dmsRowanddmsTagRowis contained within two separateif (dictMode == ZSTD_dictMatchState)sections. It is not possible to enter the second (usage) section without entering the first (initialization), but the analyser fails to see this.This change silences the "error".