Stop using deprecated reset?Stream functions#2504
Merged
Cyan4973 merged 1 commit intofacebook:devfrom Feb 23, 2021
Merged
Conversation
skitt
force-pushed
the
stop-using-resetxstream
branch
from
98bc5e2 to
2fdc883
Compare
Cyan4973
approved these changes
Feb 20, 2021
Cyan4973
reviewed
Feb 20, 2021
| } | ||
| DISPLAYLEVEL(3, "OK \n"); | ||
|
|
||
| DISPLAYLEVEL(3, "test%3i : ZSTD_resetDStream() with dictionary : ", testNb++); |
Contributor
There was a problem hiding this comment.
I would recommend not modifying the test functions,
such as the ones included in tests/zstreamtest.c
which scope includes checking static symbols.
skitt
force-pushed
the
stop-using-resetxstream
branch
from
2fdc883 to
7d9059a
Compare
Contributor
Author
|
I don’t think the FreeBSD failure is related to this patch: |
Contributor
|
Nope, FreeBSD issues are unrelated. |
Contributor
|
The changes to pzstd looks good. I'd like to revert the changes to linux-kernel. It isn't used in user-space, so it doesn't impact the static symbol usage. And I'd rather keep the implementations in the |
These are replaced by the corresponding context resets. When converting resetCStream, CCtx_setPledgedSrcSize isn't called if the source size is "unknown". This helps reduce the reliance on "static only" symbols, as well as reducing the use of deprecated functions. Signed-off-by: Stephen Kitt <[email protected]>
skitt
force-pushed
the
stop-using-resetxstream
branch
from
7d9059a to
adb5429
Compare
Contributor
Author
Done, thanks for the review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are replaced by the corresponding context resets. When
converting resetCStream, setPledgedSrcSize isn't called if the source
size is "unknown".
This helps reduce the reliance on "static only" symbols, as well as
reducing the use of deprecated functions.
Signed-off-by: Stephen Kitt [email protected]