cmake: use configure_file() for creating the .pc file#2462
Merged
terrelln merged 1 commit intofacebook:devfrom Jan 11, 2021
Merged
cmake: use configure_file() for creating the .pc file#2462terrelln merged 1 commit intofacebook:devfrom
terrelln merged 1 commit intofacebook:devfrom
Conversation
Escaping in add_custom_target() seems to depend on the shell used in the cmake generator and using Ninja on Windows, which uses cmd.exe, results in stray backslashes in the .pc file. Instead of going through escaping hell just use configure_file() with the existing libzstd.pc.in file already used by the simple Makefile based build system. This fixes the .pc file syntax when building zstd with CMake+Ninja+gcc on Windows.
Contributor
Author
|
(re-using the libzstd.pc.in might lead to breakage if it's changed in the future without realizing that it's used in two places, so I can also copy it to the cmake dir if wanted) |
Contributor
|
Awesome! I don't know why the This was causing me huge problems when I was trying to fix the escaping. I've added a test on Linux, which is passing on this PR, so looks like it is correctly escaped for Linux too. |
Contributor
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Escaping in add_custom_target() seems to depend on the shell used in the cmake
generator and using Ninja on Windows, which uses cmd.exe, results in stray backslashes
in the .pc file.
Instead of going through escaping hell just use configure_file() with the existing
libzstd.pc.in file already used by the simple Makefile based build system.
This fixes the .pc file syntax when building zstd with CMake+Ninja+gcc on Windows.