Skip to content

fix typos (work done by Andrea Gelmini)#2459

Merged
Cyan4973 merged 2 commits intofacebook:devfrom
ThomasWaldmann:fix-typos
Jan 8, 2021
Merged

fix typos (work done by Andrea Gelmini)#2459
Cyan4973 merged 2 commits intofacebook:devfrom
ThomasWaldmann:fix-typos

Conversation

@ThomasWaldmann
Copy link
Contributor

@ThomasWaldmann ThomasWaldmann commented Jan 7, 2021

Submitted on behalf of a third-party: Andrea Gelmini @Gelma

@facebook-github-bot
Copy link

Hi @ThomasWaldmann!

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@ThomasWaldmann
Copy link
Contributor Author

I don't think fixing typos is copyrightable work, so guess signing a CLA is not necessary here, right?

@Cyan4973
Copy link
Contributor

Cyan4973 commented Jan 7, 2021

Unfortunately, that's not an option.

"do not merge anything without the CLA being signed. Even typos fixes."

@ThomasWaldmann
Copy link
Contributor Author

OK, considering it was not me who found/fixed the typos, who needs to sign? Me or @Gelma?

These changes were originally part of borgbackup/borg#5597.

@Cyan4973
Copy link
Contributor

Cyan4973 commented Jan 7, 2021

Considering the process in place, it's whoever pushes the PR.

@ThomasWaldmann
Copy link
Contributor Author

OK, I signed the CLA, see also top post.

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@Cyan4973
Copy link
Contributor

Cyan4973 commented Jan 8, 2021

Thanks @ThomasWaldmann !

@Cyan4973 Cyan4973 merged commit c416015 into facebook:dev Jan 8, 2021
@ThomasWaldmann ThomasWaldmann deleted the fix-typos branch January 8, 2021 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants