Install MSVC runtime shared libraries (DLL) with cmake#2221
Install MSVC runtime shared libraries (DLL) with cmake#2221terrelln merged 2 commits intofacebook:devfrom
Conversation
|
Hi @emmenlau! Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
Thanks for the PR @emmenlau! |
|
Thanks for the quick response! |
4 participants
The cmake based build currently does not install MSVC shared libraries. This seems to be caused by a rather simple issue: The cmake install command is missing the
RUNTIMEcomponent (see https://cmake.org/cmake/help/latest/command/install.html#installing-targets). The usual install target directory for theRUNTIMEisCMAKE_INSTALL_BINDIR.This PR adds the
RUNTIMEcomponent to the install command. This should not have any negative consequences for any users. The only behavioral change should be that the shared library (dll) files will be installed intoCMAKE_INSTALL_BINDIRon MSVC, which should be a purely positive effect.