[cli] Allowing stdin on --patch-from using --stream-size#2206
Merged
bimbashrestha merged 3 commits intofacebook:devfrom Jun 18, 2020
Merged
[cli] Allowing stdin on --patch-from using --stream-size#2206bimbashrestha merged 3 commits intofacebook:devfrom
bimbashrestha merged 3 commits intofacebook:devfrom
Conversation
Cyan4973
approved these changes
Jun 18, 2020
Contributor
Author
|
The ci failure looks unrelated. I'm going to repush to make sure it is |
bimbashrestha
force-pushed
the
stream-size
branch
from
b534bef to
de48f35
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2195
A further refinement might be to guess the size of src when not provided by --stream-size. The src size won't be much bigger than the dict size so we could potentially pick
dictSize + SOME_PADDING.