Skip to content

Fix legacy build after #2103#2163

Merged
Cyan4973 merged 1 commit intofacebook:devfrom
orivej:fix-legacy-build
May 22, 2020
Merged

Fix legacy build after #2103#2163
Cyan4973 merged 1 commit intofacebook:devfrom
orivej:fix-legacy-build

Conversation

@orivej
Copy link
Contributor

@orivej orivej commented May 22, 2020

Fixes this error when building with make ZSTD_LEGACY_SUPPORT=1:

legacy/zstd_v04.c:77:10: fatal error: debug.h: No such file or directory                                                     
   77 | #include "debug.h"                                                                                                   

@facebook-github-bot
Copy link

Hi @orivej!

Thank you for your pull request and welcome to our community.We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@Cyan4973
Copy link
Contributor

Thanks @orivej , that's a pretty straightforward fix !

@Cyan4973 Cyan4973 merged commit e20b601 into facebook:dev May 22, 2020
@Cyan4973
Copy link
Contributor

Cyan4973 commented May 22, 2020

cc @felixhandte
I'm wondering why our test suite missed that one.
I was expecting one of our "last stage" test to cover compilation of older legacy units.
If that's not the case, we should have this test. I'm unsure now if similar issue are present in legacy decoders 1-2-3.

@orivej orivej deleted the fix-legacy-build branch May 23, 2020 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants