[ldm] Reset loadedDictEnd when the context is reset#2150
Merged
terrelln merged 3 commits intofacebook:devfrom May 19, 2020
Merged
[ldm] Reset loadedDictEnd when the context is reset#2150terrelln merged 3 commits intofacebook:devfrom
terrelln merged 3 commits intofacebook:devfrom
Conversation
Cyan4973
approved these changes
May 18, 2020
terrelln
force-pushed
the
ldm-dict-reset
branch
2 times, most recently
from
37aa1a4 to
7b317b4
Compare
Contributor
Author
|
Added a test. |
Cyan4973
approved these changes
May 18, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
loadedDictEndwhen we reset the contextloadedDictEndwhen we do overflow correctionAdded a test that produces an out of bounds offset before this fix, and works after.
Credit to OSS-Fuzz