Reduced single file lib size on macOS#2146
Merged
felixhandte merged 2 commits intofacebook:devfrom May 18, 2020
cwoffenden:combine-script-fixes
Merged
Reduced single file lib size on macOS#2146felixhandte merged 2 commits intofacebook:devfrom cwoffenden:combine-script-fixes
felixhandte merged 2 commits intofacebook:devfrom
cwoffenden:combine-script-fixes
Conversation
…ssing) Added Python fallback for when realpath fails.
Contributor
Author
|
Travis CI failed with "too many requests" and the fuzzer failure is (I believe) unrelated (the codebase wasn't changed outside of the single file lib folder). |
felixhandte
approved these changes
May 18, 2020
Contributor
felixhandte
left a comment
felixhandte
left a comment
There was a problem hiding this comment.
I've verified that this succeeds locally.
Thanks for this contribution!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #2103 the generated file sizes are much larger on macOS (and any other environment where
realpathis missing). This adds a Python fallback to bring the file sizes back to what they were.