[lib] Fix bug in loading LDM dictionary in MT mode#2138
Merged
terrelln merged 2 commits intofacebook:devfrom May 14, 2020
Merged
[lib] Fix bug in loading LDM dictionary in MT mode#2138terrelln merged 2 commits intofacebook:devfrom
terrelln merged 2 commits intofacebook:devfrom
Conversation
Exposed when loading a dictionary < LDM minMatch bytes in MT mode. Test Plan: ``` CC=clang make -j zstreamtest MOREFLAGS="-O0 -fsanitize=address" ./zstreamtest -vv -i100000000 -t1 --newapi -s7065 -t3925297 ``` TODO: Add an explicit test that loads a small dictionary in MT mode
bimbashrestha
approved these changes
May 14, 2020
Contributor
|
Thanks @terrelln ! The fix looks good to me. |
Contributor
Author
Currently writing it. |
Contributor
Author
|
Unit test added. |
Cyan4973
approved these changes
May 14, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exposed when loading a dictionary < LDM minMatch bytes in MT mode.
Test Plan:
Add a unit test that catches the bug, and run the zstreamtest reproducer.