Migrate Includes to Relative Paths#2103
Merged
felixhandte merged 10 commits intofacebook:devfrom May 6, 2020
Merged
Conversation
felixhandte
force-pushed
the
relative-includes
branch
2 times, most recently
from
cb393cc to
e7cfa86
Compare
felixhandte
force-pushed
the
relative-includes
branch
from
e7cfa86 to
b48f6c7
Compare
Contributor
|
Looks like the single file decoder is still failing |
terrelln
approved these changes
May 4, 2020
Contributor
terrelln
left a comment
terrelln
left a comment
There was a problem hiding this comment.
LGTM once the tests pass though.
Cyan4973
approved these changes
May 6, 2020
Contributor
|
Great work @felixhandte ! |
Contributor
|
The changes to the single-file generator script inlines files multiple times. For example, The resulting binary file is the same, and the include guards do their job against these multiple copies, but the resulting |
Merged
orivej
added a commit
to orivej/zstd
that referenced
this pull request
May 22, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes the need for adding our subdirectories to the compiler's include path (via
-Ilib,-Ilib/common, etc.), both for our own builds, and for those who copy the zstd source in their own source tree and build using their own build system.This PR addresses #1998.
Tested with make and cmake. Will let contbuild test the other build systems.