[memory opt] Downsize decompression buffers when large for too long#2069
[memory opt] Downsize decompression buffers when large for too long#2069bimbashrestha merged 8 commits intofacebook:devfrom
Conversation
|
Please add a test, you should be able to use |
felixhandte
left a comment
There was a problem hiding this comment.
Looks pretty good overall. Suggestions inline.
|
Looks good to me. It's a clean patch, great work @bimbashrestha ! And just FYI, since I did not participate on earlier discussion on this topic, I was not opposed on having separate constants for compression and decompression states, since it would allow differentiated policy if need be. But indeed, the names of constants should reflect their respective scope. That being said, there's no urgency. We can start by using the same constants and therefore same policy for both |
terrelln
left a comment
There was a problem hiding this comment.
LGTM once the test is added.
#2066