Adding --no-content-size to the cli#2032
Conversation
terrelln
left a comment
There was a problem hiding this comment.
Please add a test to playTests.sh. You can use zstd -l or zstd -lv to check if the frame content size is written into the frame.
|
Consider adding a line about this new command in |
|
I think the only explicit use case is about compressing a file which is being appended to at the same time, thus changing its size during the compression process. Setting the size to In contrast, just disabling the content size field, using My own preference would be for the second case, though I have no "strong" reason for that, just some "gut feeling", essentially because it feels closer to the expressed command : "no-content-size", rather than "no-content-size-and-assume-large-file". But anyway, I suspect the difference between these 2 options is pretty small and won't matter much. |
|
I'm in favor of keeping parameter adjustment as well. |
|
Ah okay then! Haden't thought about changing parameters honestly but that makes sense to me. I'll change it to unset ZSTD_c_contentSizeFlag instead of setting filesize to unknown. |
terrelln
left a comment
There was a problem hiding this comment.
LGTM once Travis is passing
|
I thought I noticed Travis failing but it's okay now. Guess it was flakey:/ |
Yeah, I re-ran it and it passed. Seemed to be some infra flakiness, because it was a super weird issue. |
#1926
Ran
and