[opt] Don't recompute initial literals price#2028
Merged
terrelln merged 3 commits intofacebook:devfrom Mar 5, 2020
Merged
Conversation
Contributor
|
OK, so the main idea seems to be that |
Contributor
Author
|
Yup, I've added a comment saying that. We don't "need" the cost of the literal length either, but I don't want the price to be negative when we subtract it off later. |
Cyan4973
approved these changes
Mar 5, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The pricing of
opt[0].pricedoesn't matter at all for the parsing, since every path containsopt[0]. I've left thelitlenprice in so we don't get negative prices when we subtract it off.I don't expect more than any real gains, except maybe on a specifically constructed dataset, but no need to do the extra work.