Skip to content

Replaced targetLen with targetLength#2010

Closed
eyherabh wants to merge 1 commit intofacebook:devfrom
eyherabh:patch-3
Closed

Replaced targetLen with targetLength#2010
eyherabh wants to merge 1 commit intofacebook:devfrom
eyherabh:patch-3

Conversation

@eyherabh
Copy link

The actual name of the option is targetLength. Using targetLen, as previously indicated, resulted in errors.

The actual name of the option is targetLength. Using targetLen, as previously indicated, resulted in errors.
@facebook-github-bot
Copy link

Hi @eyherabh!

Thank you for your pull request and welcome to our community.We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@Cyan4973
Copy link
Contributor

Thanks @eyherabh ,
the proposed correction looks good !
We will just need the CLA signed before the merge.

@bimbashrestha
Copy link
Contributor

@eyherabh ping:) Just need the cla signed

@bimbashrestha
Copy link
Contributor

It's been a while since this pr was active so I've just went ahead and merged the changes in my linked pr. Thanks for the find @eyherabh!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants