Closed
Conversation
terrelln
changed the title
terrelln
changed the title
Contributor
Author
|
I'm going to go ahead and close this PR. We can revive it if we want to enable |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the
RETURN_ERRORmacro and friends to have aRETURN_ERROR_MSGmacro to avoid empty__VA_ARGS__.We can't enable the flag to detect this, since it is gcc only. We can't enable
-pedanticright now because it is too noisy. It would take quite some work to enable, and we'd have to disable certain parts, so the parts we'd have to disable would have to be consistent across compilers.Fixes #1538.