-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Closed
Labels
Portabilityenhancementrefactorrelease-blockingMust be done by the releaseMust be done by the release
Description
Thanks for a fantastic library!
When compiling with the -pedantic option a lot of ISO C99 warnings are generated, an example of which is
d:/Compiler/gcc-4.9.3/mingw_32/bin/gcc -I"D:/RCompile/recent/R/include" -DNDEBUG -I. -Ifstcore -Ifstcore_v1 -Ifstcore/LZ4 -Ifstcore/ZSTD -Ifstcore/ZSTD/common -Ifstcore/ZSTD/decompress -Ifstcore/ZSTD/compress -I'D:/RCompile/CRANpkg/lib/4.0/Rcpp/include' -I"d:/Compiler/gcc-4.9.3/local330/include" -pedantic -O2 -Wall -std=gnu99 -mtune=core2 -c fstcore/ZSTD/decompress/zstd_decompress.c -o fstcore/ZSTD/decompress/zstd_decompress.o
fstcore/ZSTD/decompress/zstd_decompress.c: In function 'ZSTD_frameHeaderSize_internal':
fstcore/ZSTD/decompress/zstd_decompress.c:211:58: warning: ISO C99 requires rest arguments to be used
RETURN_ERROR_IF(srcSize < minInputSize, srcSize_wrong);
These warnings are due to macro's defined with ellipses that are left empty when called, like the macro's defined in this code.
Currently, R packages submitted to CRAN that include ZSTD as part of their source code fail the acceptance pre-tests because of these warnings. Would it be possible to include the -pedantic option in your gcc builds to help fix them?
thanks and all the best
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
Portabilityenhancementrefactorrelease-blockingMust be done by the releaseMust be done by the release