Fix an race condition during multiple DB opening#8574
Closed
jay-zhuang wants to merge 3 commits intofacebook:masterfrom
Closed
Fix an race condition during multiple DB opening#8574jay-zhuang wants to merge 3 commits intofacebook:masterfrom
jay-zhuang wants to merge 3 commits intofacebook:masterfrom
Conversation
Summary: ObjectLibrary is shared between multiple DB instances, the Register() could have race condition. Test Plan: pass the failed test
Contributor
|
@jay-zhuang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Contributor
|
@jay-zhuang merged this pull request in c4a503f. |
jay-zhuang
added a commit
that referenced
this pull request
Jul 22, 2021
Summary: ObjectLibrary is shared between multiple DB instances, the Register() could have race condition. Pull Request resolved: #8574 Test Plan: pass the failed test Reviewed By: ajkr Differential Revision: D29855096 Pulled By: jay-zhuang fbshipit-source-id: 541eed0bd495d2c963d858d81e7eabf1ba16153c
azat
pushed a commit
to azat-archive/rocksdb
that referenced
this pull request
Sep 26, 2021
Summary: ObjectLibrary is shared between multiple DB instances, the Register() could have race condition. Pull Request resolved: facebook#8574 Test Plan: pass the failed test Reviewed By: ajkr Differential Revision: D29855096 Pulled By: jay-zhuang fbshipit-source-id: 541eed0bd495d2c963d858d81e7eabf1ba16153c (cherry picked from commit c4a503f)
azat
added a commit
to ClickHouse/rocksdb
that referenced
this pull request
Sep 26, 2021
Backport: Fix an race condition during multiple DB opening (facebook#8574)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: ObjectLibrary is shared between multiple DB instances, the
Register() could have race condition.
Test Plan: pass the failed test