More details for 'tail prefetch size is calculated based on'#12667
More details for 'tail prefetch size is calculated based on'#12667andlr wants to merge 5 commits intofacebook:mainfrom
Conversation
|
@hx235 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
ajkr
left a comment
ajkr
left a comment
There was a problem hiding this comment.
It is a warning so we can track use cases that are at risk of regression when we finally remove TailPrefetchStats. The warnings and the risk can be mitigated by running compaction with a new enough RocksDB version (see #12664). If you still wanted to make a code change here, may I suggest a couple ideas:
- As you mentioned the documentation was inadequate to know what to do. Maybe the warning text or surrounding comments could be improved.
- Deduplicating the error could help with the spam problem. Maybe one warning per DB open saying N files are at risk.
|
@andlr has updated the pull request. You must reimport the pull request before landing. |
andlr
changed the title
Thanks for the explanation. I think in such case, it's probably enough to add name of the SST file into the log message, and a comment in code, saying that this backward compatibility won't be preserved forever |
|
@hx235 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@andlr has updated the pull request. You must reimport the pull request before landing. |
|
@hx235 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@andlr has updated the pull request. You must reimport the pull request before landing. |
|
@andlr has updated the pull request. You must reimport the pull request before landing. |
|
@hx235 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
…k#12667) Summary: These messages indicate that SST file was created by a pre-9.0.0 RocksDB. Eventually, `TailPrefetchStats` might be removed, so it would be more informative if log message also included name of the affected SST file. Issue: facebook#12664 Pull Request resolved: facebook#12667 Reviewed By: ajkr Differential Revision: D57464025 Pulled By: hx235 fbshipit-source-id: 12f2f2635e3092f8c29362aa132462492b5c1417
4 participants
These messages indicate that SST file was created by a pre-9.0.0 RocksDB. Eventually,
TailPrefetchStatsmight be removed, so it would be more informative if log message also included name of the affected SST file.Issue: #12664