Closed
Conversation
slorber
commented
Apr 23, 2021
slorber
commented
Apr 23, 2021
Contributor
Author
|
ready for review |
Contributor
|
@jstejada has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Contributor
|
@jstejada has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Contributor
|
nvm i was making a mistake, attempting to land this locally now |
Contributor
Contributor
|
@jsteiner @slorber I think this change causes an issue with zIndexes on the relay docs site:
|
Contributor
Author
|
Hi
I'm sorry but I'm in holiday until 1st June
I believe this is some custom css on relay, as other docusaurus sites don't
have this problem
Le ven. 21 mai 2021 à 16:16, Christian Vuerings ***@***.***>
a écrit :
… @jsteiner <https://github.com/jsteiner> @slorber
<https://github.com/slorber> I think this change causes an issue with
zIndexes on the relay docs site:
[image: image]
<https://user-images.githubusercontent.com/127199/119151401-35317000-ba04-11eb-8d75-2ff3524867bb.png>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3469 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAFW6PWORYI7DKHRQWFG7EDTOZTKNANCNFSM43ON326Q>
.
|
Closed
Contributor
Author
|
Fixing website CSS issue in #3505 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Jun 3, 2021
Summary: Docusaurus beta 0 has been released so let's use it! Also, you are currently affected by an annoying regression in a Docusaurus transitive dependency ([email protected] => facebook/docusaurus#4826) Reported by christianvuerings here: #3469 (comment)  This should now be fixed by re-generating the lockfile. Pull Request resolved: #3505 Reviewed By: kassens Differential Revision: D28874560 Pulled By: rbalicki2 fbshipit-source-id: 6baece255be570abd5ec5f19f10e7f503be482f9
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use an unreleased version of Docusaurus to test the webpack5 support works for this site, detect potential problems, and perf improvements.
See also facebook/docusaurus#4089
Perf improvements
To get the benefits, it requires caching
node_modules/.cache.It is not possible in GH actions, so I suggest migrating the site to Netlify and use the appropriate toml config (example: https://github.com/react-navigation/react-navigation.github.io/pull/974/files)
Unrelated suggestion: Relay has a lot of versions and long build/start times
Assuming nobody ever edit Relay docs of 2 years ago, you can improve the DX by limiting the number of versions display in dev with this docs plugin config:
For faster prod build, you can also move older docs to standalone deployments and link to them (see Jest for versions < 25 => https://jestjs.io/)