fix(codegen): ensure unique c++ variable names to avoid collision for properties with the same name #53852
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
mfazekas
changed the title
${properyName}_${idx} pattern for naming variables to avoid using same variable for different properties
facebook-github-bot
added
the
Shared with Meta
cortinico
reviewed
Sep 19, 2025
...gen/e2e/deep_imports/__tests__/components/__snapshots__/GenerateEventEmitterCpp-test.js.snap
Outdated
Show resolved
Hide resolved
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Member
|
Thanks for the fix! Could we make this even more explicit by using variable names such as |
Contributor
cc @mfazekas |
Contributor
Author
Just to clarify if name is |
mfazekas
force-pushed
the
mfazekas/fix-codegen-varnames
branch
from
796d4cb to
6ce639b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Fixes: #53839
Codegen uses object propertyNames as variable names. This breaks if the same property names appears at multiple levels. Also breaks if a property is called
payloadas payload is a variable name already used.Before the fix codegen could generate code like this:
Changelog:
[GENERAL] [FIXED] - Fix Codegen to use unique variable names to avoid name collisions in corner cases
Test Plan: