Fix virtualization logic with horizontal RTL lists #38529
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D46586420 |
github-actions
bot
added
the
Needs: Repro
Base commit: d380bb8 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Jul 20, 2023
Summary: Pull Request resolved: facebook#38529 VirtualizedList internally represents metrics along the scrolling axis using `offset` (x, y), and `length` (width, height). This one dimensional representation allows the list to be generic to being horizontal or vertical. Right now offset conversion directly takes the `x` or `y` axis value, but this is not correct when we are using a horizontal FlatList in RTL. This change converts most VirtualizedList code handling `offset,length` coordinates consistently flow from start to end, including in horizontal RTL and in inverted FlatList. This is paired with a fix to Android native code in D47627115. With these together, basic Horizontal FlatList scenarios should work correctly when laid out in RTL. Differential Revision: D46586420 fbshipit-source-id: ac75b7d743141ff03cc9d6d3fd2d328fe8994b54
NickGerleman
force-pushed
the
export-D46586420
branch
from
1ff698d to
8bfc118
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D46586420 |
1 similar comment
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D46586420 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Jul 25, 2023
Summary: Pull Request resolved: facebook#38529 VirtualizedList internally represents metrics along the scrolling axis using `offset` (x, y), and `length` (width, height). This one dimensional representation allows the list to be generic to being horizontal or vertical. Right now offset conversion directly takes the `x` or `y` axis value, but this is not correct when we are using a horizontal FlatList in RTL. This change converts most VirtualizedList code handling `offset,length` coordinates consistently flow from start to end, including in horizontal RTL and in inverted FlatList. This is paired with a fix to Android native code in D47627115. With these together, basic Horizontal FlatList scenarios should work correctly when laid out in RTL. Differential Revision: D46586420 fbshipit-source-id: ea18a7b29c05be4eb4d212bc92475a2a7fb733a0
NickGerleman
force-pushed
the
export-D46586420
branch
from
8bfc118 to
4e3e6d2
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D46586420 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Jul 25, 2023
Summary: Pull Request resolved: facebook#38529 VirtualizedList internally represents metrics along the scrolling axis using `offset` (x, y), and `length` (width, height). This one dimensional representation allows the list to be generic to being horizontal or vertical. Right now offset conversion directly takes the `x` or `y` axis value, but this is not correct when we are using a horizontal FlatList in RTL. This change converts most VirtualizedList code handling `offset,length` coordinates consistently flow from start to end, including in horizontal RTL and in inverted FlatList. This is paired with a fix to Android native code in D47627115. With these together, basic Horizontal FlatList scenarios should work correctly when laid out in RTL. Differential Revision: D46586420 fbshipit-source-id: ea475f61008d9ea69bf512778ec42d47b77ca7c0
NickGerleman
force-pushed
the
export-D46586420
branch
from
4e3e6d2 to
2c6449a
Compare
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Jul 27, 2023
Summary: Pull Request resolved: facebook#38529 VirtualizedList internally represents metrics along the scrolling axis using `offset` (x, y), and `length` (width, height). This one dimensional representation allows the list to be generic to being horizontal or vertical. Right now offset conversion directly takes the `x` or `y` axis value, but this is not correct when we are using a horizontal FlatList in RTL. This change converts most VirtualizedList code handling `offset,length` coordinates consistently flow from start to end, including in horizontal RTL and in inverted FlatList. This is paired with a fix to Android native code in D47627115. With these together, basic Horizontal FlatList scenarios should work correctly when laid out in RTL. Reviewed By: vincentriemer Differential Revision: D46586420 fbshipit-source-id: 58be7fe4e4cec31aa73146239d0c2c0929b9d0f6
NickGerleman
force-pushed
the
export-D46586420
branch
from
2c6449a to
3255cdd
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D46586420 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Jul 27, 2023
Summary: Pull Request resolved: facebook#38529 VirtualizedList internally represents metrics along the scrolling axis using `offset` (x, y), and `length` (width, height). This one dimensional representation allows the list to be generic to being horizontal or vertical. Right now offset conversion directly takes the `x` or `y` axis value, but this is not correct when we are using a horizontal FlatList in RTL. This change converts most VirtualizedList code handling `offset,length` coordinates consistently flow from start to end, including in horizontal RTL and in inverted FlatList. This is paired with a fix to Android native code in D47627115. With these together, basic Horizontal FlatList scenarios should work correctly when laid out in RTL. Changelog: [General][Fixed] - Fix virtualization logic with horizontal RTL lists Reviewed By: vincentriemer Differential Revision: D46586420 fbshipit-source-id: 56a29abc4bdf3b9505b510bcc207fd750c3c08a7
NickGerleman
force-pushed
the
export-D46586420
branch
from
3255cdd to
3ce1744
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D46586420 |
Summary: This changes the logic we use to correct scroll position on RTL ScrollView content change, to a new more generalized strategy of keeping a constant right-edge offset on layout change. This includes first layout, so that the initial scroll position is correct. Differential Revision: D47627115 fbshipit-source-id: c8964046dcb4cf33424a593e1372a3a8dd3a91df
Summary: Pull Request resolved: facebook#38529 VirtualizedList internally represents metrics along the scrolling axis using `offset` (x, y), and `length` (width, height). This one dimensional representation allows the list to be generic to being horizontal or vertical. Right now offset conversion directly takes the `x` or `y` axis value, but this is not correct when we are using a horizontal FlatList in RTL. This change converts most VirtualizedList code handling `offset,length` coordinates consistently flow from start to end, including in horizontal RTL and in inverted FlatList. This is paired with a fix to Android native code in D47627115. With these together, basic Horizontal FlatList scenarios should work correctly when laid out in RTL. Changelog: [General][Fixed] - Fix virtualization logic with horizontal RTL lists Reviewed By: vincentriemer Differential Revision: D46586420 fbshipit-source-id: 6224fc310035766f7b2473adfd170093119524a7
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D46586420 |
NickGerleman
force-pushed
the
export-D46586420
branch
from
3ce1744 to
49c7cb6
Compare
Contributor
|
This pull request has been merged in 8b39bfa. |
billnbell
pushed a commit
to billnbell/react-native
that referenced
this pull request
Jul 29, 2023
Summary: Pull Request resolved: facebook#38529 VirtualizedList internally represents metrics along the scrolling axis using `offset` (x, y), and `length` (width, height). This one dimensional representation allows the list to be generic to being horizontal or vertical. Right now offset conversion directly takes the `x` or `y` axis value, but this is not correct when we are using a horizontal FlatList in RTL. This change converts most VirtualizedList code handling `offset,length` coordinates consistently flow from start to end, including in horizontal RTL and in inverted FlatList. This is paired with a fix to Android native code in D47627115. With these together, basic Horizontal FlatList scenarios should work correctly when laid out in RTL. Changelog: [General][Fixed] - Fix virtualization logic with horizontal RTL lists Reviewed By: vincentriemer Differential Revision: D46586420 fbshipit-source-id: 79594e197d21871bb493399999e91fc0d6c7b050
billnbell
pushed a commit
to billnbell/react-native
that referenced
this pull request
Jul 29, 2023
Summary: Pull Request resolved: facebook#38529 VirtualizedList internally represents metrics along the scrolling axis using `offset` (x, y), and `length` (width, height). This one dimensional representation allows the list to be generic to being horizontal or vertical. Right now offset conversion directly takes the `x` or `y` axis value, but this is not correct when we are using a horizontal FlatList in RTL. This change converts most VirtualizedList code handling `offset,length` coordinates consistently flow from start to end, including in horizontal RTL and in inverted FlatList. This is paired with a fix to Android native code in D47627115. With these together, basic Horizontal FlatList scenarios should work correctly when laid out in RTL. Changelog: [General][Fixed] - Fix virtualization logic with horizontal RTL lists Reviewed By: vincentriemer Differential Revision: D46586420 fbshipit-source-id: 79594e197d21871bb493399999e91fc0d6c7b050
billnbell
pushed a commit
to billnbell/react-native
that referenced
this pull request
Jul 29, 2023
Summary: Pull Request resolved: facebook#38529 VirtualizedList internally represents metrics along the scrolling axis using `offset` (x, y), and `length` (width, height). This one dimensional representation allows the list to be generic to being horizontal or vertical. Right now offset conversion directly takes the `x` or `y` axis value, but this is not correct when we are using a horizontal FlatList in RTL. This change converts most VirtualizedList code handling `offset,length` coordinates consistently flow from start to end, including in horizontal RTL and in inverted FlatList. This is paired with a fix to Android native code in D47627115. With these together, basic Horizontal FlatList scenarios should work correctly when laid out in RTL. Changelog: [General][Fixed] - Fix virtualization logic with horizontal RTL lists Reviewed By: vincentriemer Differential Revision: D46586420 fbshipit-source-id: 79594e197d21871bb493399999e91fc0d6c7b050
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
VirtualizedList internally represents metrics along the scrolling axis using
offset(x, y), andlength(width, height). This one dimensional representation allows the list to be generic to being horizontal or vertical.Right now offset conversion directly takes the
xoryaxis value, but this is not correct when we are using an inverted FlatList, or a horizontal FlatList in RTL.This change converts most VirtualizedList code handling
offset,lengthcoordinates consistently flow from start to end, including in horizontal RTL and in inverted FlatList.This is paired with a fix to Android native code in D47627115. With these together, basic Horizontal FlatList scenarios should work correctly when laid out in RTL.
Differential Revision: D46586420