[Android] Fixed template build gradle error on x86_64#23897
[Android] Fixed template build gradle error on x86_64#23897zhongwuzw wants to merge 1 commit intofacebook:masterfrom
Conversation
|
The fact this issue has been in master for 2.5 months without it being caught is troublesome. Can you try adding a test to make sure we don't regress here in the future? |
|
@hramos Seem we have no way to build on |
|
I think we should add tests for the template, which will initialize a new project then build it for both Android and iOS. For Android, we can analyze APKs and check for dynamic libraries. |
|
Right now, we manually test inited app - I guess we could factor in other architectures. |
|
I think it's best to merge this PR and open an issue about template tests. |
facebook-github-bot
left a comment
There was a problem hiding this comment.
@hramos is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
This pull request was successfully merged by @zhongwuzw in 4aa731a. When will my fix make it into a release? | Upcoming Releases |
Summary
Fixes #23893 . Fixes x86_64 apk build.
Changelog
[Android] [Fixed] - Fixed template build gradle error on x86_64
Test Plan
CI passes.