Fix crash from setProperty in RCTTurboModule

weih9 · facebook-github-bot · commit caf80d442b57 · 2023-03-02T10:31:21.000-08:00
Summary:
Changelog[Internal]:
[iOS][Fixed] - Fix crash from calling setProperty in RCTTurboModule

The crash is caused by passing a utf8 encoded string to a Object::setProperty overload which only allows ascii inputs.

Reviewed By: RSNara

Differential Revision: D43705999

fbshipit-source-id: b3f1b3fd27d43d40fe0a170d4c2e60faecc26dad
diff --git a/ReactCommon/react/nativemodule/core/platform/ios/ReactCommon/RCTTurboModule.mm b/ReactCommon/react/nativemodule/core/platform/ios/ReactCommon/RCTTurboModule.mm
@@ -59,7 +59,7 @@ static int32_t getUniqueId()
 {
   jsi::Object result = jsi::Object(runtime);
   for (NSString *k in value) {
-    result.setProperty(runtime, [k UTF8String], convertObjCObjectToJSIValue(runtime, value[k]));
+    result.setProperty(runtime, convertNSStringToJSIString(runtime, k), convertObjCObjectToJSIValue(runtime, value[k]));
   }
   return result;
 }

Original file line number	Diff line number	Diff line change
`@@ -59,7 +59,7 @@ static int32_t getUniqueId()`
`59`	`59`	`{`
`60`	`60`	`jsi::Object result = jsi::Object(runtime);`
`61`	`61`	`for (NSString *k in value) {`
`62`		`- result.setProperty(runtime, [k UTF8String], convertObjCObjectToJSIValue(runtime, value[k]));`
	`62`	`+ result.setProperty(runtime, convertNSStringToJSIString(runtime, k), convertObjCObjectToJSIValue(runtime, value[k]));`
`63`	`63`	`}`
`64`	`64`	`return result;`
`65`	`65`	`}`