Skip to content

Commit a5d5ead

Browse files
cortinicofacebook-github-bot
authored andcommitted
Make sure template is consuming the right buildToolsVersion (#39956)
Summary: Currently, the template has a `buildToolsVersion = '34.0.0'` specified in the top level .gradle file but it's not currently using it. This is causing the build to fallback to the default version provided by AGP which is 33.x This is also causing the CI to download buildtools 34.0.0 as they're not in the container (causing network flakyness). I'm also bumping the docker container to v12 as we bumped NDK 26 which is missing in the v11 container. ## Changelog: [INTERNAL] [FIXED] - Make sure template is consuming the right buildToolsVersion Pull Request resolved: #39956 Test Plan: CI should be green Reviewed By: christophpurrer Differential Revision: D50019777 Pulled By: cortinico fbshipit-source-id: a2ab7a7bd7c55624d5c050b45e69086c5f25ba6a
1 parent 4d70337 commit a5d5ead

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

.circleci/configurations/top_level.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ references:
2525
android-defaults: &android-defaults
2626
working_directory: ~/react-native
2727
docker:
28-
- image: reactnativecommunity/react-native-android:v11.0
28+
- image: reactnativecommunity/react-native-android:v12.0
2929
environment:
3030
- TERM: "dumb"
3131
- GRADLE_OPTS: '-Dorg.gradle.daemon=false'

packages/react-native/template/android/app/build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ def jscFlavor = 'org.webkit:android-jsc:+'
7171

7272
android {
7373
ndkVersion rootProject.ext.ndkVersion
74-
74+
buildToolsVersion rootProject.ext.buildToolsVersion
7575
compileSdk rootProject.ext.compileSdkVersion
7676

7777
namespace "com.helloworld"

0 commit comments

Comments
 (0)